chore: require minimum httpcore with security fix for h11#3691
Closed
danielfcollier wants to merge 1 commit intoencode:masterfrom
Closed
chore: require minimum httpcore with security fix for h11#3691danielfcollier wants to merge 1 commit intoencode:masterfrom
danielfcollier wants to merge 1 commit intoencode:masterfrom
Conversation
|
Nice work! |
Contributor
|
Duplicate of #3560 |
I'm trying to understand what this means: are you saying that httpx will not update its dependency to resolve this security issue? Or am I misunderstanding this? |
Contributor
|
Yes there's no need to change the minimum required version for users to receive the security fix as was discussed at length in #3564 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
httpcoresubdependencyh11has a security fix for the critical security issue that requires the minimum version1.0.9.References:
Checklist